Do not store DFK in PolledExecutorFacade #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DFK is only used to initialise monitoring, in __init__, and is not used after that. The object that lives beyond __init__ is self.hub_channel. This PR should not change behaviour.
khk-globus
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DFK is only used to initialise monitoring, in
__init__, and is not used after that. The object that lives beyond__init__isself.hub_channel.This is part of work to move
JobStatusPollerfacade state into other classes, as part of job handling rearrangements in PR #3293Changed Behaviour
This PR should not change behaviour.
Type of change